[webkit-reviews] review denied: [Bug 16924] Shared PluginDatabase, PluginPackage, and PlugInInfoStore Implementations : [Attachment 19120] Patch to implement PluginDatabase as shared and use PluginInfoStore for GTK+, Qt, and Wx

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has denied Rodney Dawes
<dobey at wayofthemonkey.com>'s request for review:
Bug 16924: Shared PluginDatabase, PluginPackage, and PlugInInfoStore
Implementations
http://bugs.webkit.org/show_bug.cgi?id=16924

Attachment 19120: Patch to implement PluginDatabase as shared and use
PluginInfoStore for GTK+, Qt, and Wx
http://bugs.webkit.org/attachment.cgi?id=19120&action=edit

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
This mostly looks good, although it does break the Windows build, because
PluginPackage::storeFileVersion was removed but is still in
PluginPackageWin.cpp.

I think a good fix would be to add an abstraction for a PlatformModuleVersion
and make storeModuleVersion a static helper function.

+PluginSet PluginDatabase::getPluginsInPaths() const { notImplemented();
PluginSet plugins; return plugins;}
+Vector<String> PluginDatabase::defaultPluginPaths() { notImplemented();
Vector<String> paths; return paths;}

No need to name the return values, need a space before closing brace.

+bool PluginPackage::fetchInfo() { notImplemented(); return false;}
+unsigned PluginPackage::hash() const { notImplemented(); return 0;}

Need a space before closing brace.

r- for the build breakage, but I think this looks great.