[webkit-reviews] review granted: [Bug 17353] XMLTokenizer installs global libxml2 callbacks that can break client applications : [Attachment 19125] Proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alp Toker <alp at atoker.com>'s request
for review:
Bug 17353: XMLTokenizer installs global libxml2 callbacks that can break client
applications
http://bugs.webkit.org/show_bug.cgi?id=17353

Attachment 19125: Proposed fix
http://bugs.webkit.org/attachment.cgi?id=19125&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me, with some reservations.

Doesn't this still leave us with the problem that other libxml2 clients could
call xmlRegisterInputCallbacks and clobber our callbacks with their own? Is
there a "save and restore" approach we could use instead?

Should we file a bug asking libxml2 to come up with a way of doing this that's
not global?

+    // TODO: We should restore the original global error handler as well.

We use FIXME, not TODO, for these things.