[webkit-reviews] review granted: [Bug 17220] Illogical dependency between PluginView and PluginDatabase : [Attachment 19067] Updated patch with Jon's suggestions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 13 08:14:59 PST 2008


Adam Roben <aroben at apple.com> has granted 's request for review:
Bug 17220: Illogical dependency between PluginView and PluginDatabase
http://bugs.webkit.org/show_bug.cgi?id=17220

Attachment 19067: Updated patch with Jon's suggestions
http://bugs.webkit.org/attachment.cgi?id=19067&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+#include "KURL.h"
 #include "PlatformString.h"
 #include "PluginPackage.h"
 #include "StringHash.h"
@@ -37,7 +38,6 @@ namespace WebCore {
     class Element;
     class Frame;
     class IntSize;
-    class KURL;

I know Jon said to include KURL.h, but I think he was mistaken and it's not
really needed. Everything should compile fine with just a forward declaration,
so you should be able to undo this change.

r=me


More information about the webkit-reviews mailing list