[webkit-reviews] review granted: [Bug 17269] Deobfuscate
CanvasRenderingContext2D.cpp : [Attachment 19089] Different
tack, lets fix HTMLCanvasElement first
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 12 00:29:07 PST 2008
Alp Toker <alp at atoker.com> has granted Oliver Hunt <oliver at apple.com>'s request
for review:
Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
http://bugs.webkit.org/show_bug.cgi?id=17269
Attachment 19089: Different tack, lets fix HTMLCanvasElement first
http://bugs.webkit.org/attachment.cgi?id=19089&action=edit
------- Additional Comments from Alp Toker <alp at atoker.com>
cairo_surface_t* HTMLCanvasElement::createPlatformImage() const
{
- if (!m_surface)
+ if (!m_data)
return 0;
// Note that unlike CG, our returned image is not a copy or
// copy-on-write, but the original. This is fine, since it is only
// ever used as a source.
- cairo_surface_flush(m_surface);
- cairo_surface_reference(m_surface);
+ cairo_surface_flush(m_data->surface());
+ cairo_surface_reference(m_data->surface());
return m_surface;
}
^ Should be return m_data->surface();
Otherwise looks great.
More information about the webkit-reviews
mailing list