[webkit-reviews] review granted: [Bug 17269] Deobfuscate CanvasRenderingContext2D.cpp : [Attachment 19057] Setting up a pattern for stroke style is no longer ifdef hell

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
http://bugs.webkit.org/show_bug.cgi?id=17269

Attachment 19057: Setting up a pattern for stroke style is no longer ifdef hell
http://bugs.webkit.org/attachment.cgi?id=19057&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I'm not happy with the approach you're taking here. You're creating these
lightweight abstractions on top of the platforms, rather than creating some
real C++ objects that go along with GraphicsContext. I'd strongly prefer the
latter.

These objects that you have to manually call retain and release on are not a
good fit for WebCore's platform layer.

+	
CGAffineTransformTranslate(CGAffineTransformScale((CGAffineTransform)transform,
1, -1), 0, -rect.size.height);

+    cairo_matrix_t cm = (cairo_matrix_t)m;

Please don't use C-style casts in new code.

r=me, but lets talk about finding a better design pattern for this work