[webkit-reviews] review granted: [Bug 17259] Element::recalcStyle()
needlessly null-checks the result of styleForElement() :
[Attachment 19019] Remove unneeded null checks
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 9 15:58:12 PST 2008
Sam Weinig <sam at webkit.org> has granted mitz at webkit.org's request for review:
Bug 17259: Element::recalcStyle() needlessly null-checks the result of
styleForElement()
http://bugs.webkit.org/show_bug.cgi?id=17259
Attachment 19019: Remove unneeded null checks
http://bugs.webkit.org/attachment.cgi?id=19019&action=edit
------- Additional Comments from Sam Weinig <sam at webkit.org>
This looks good to me, but as discussed, a better word than redundant should be
used to describe why the null checks aren't needed. Just stating that
styleForElement() cannot return null should be sufficient.
More information about the webkit-reviews
mailing list