[webkit-reviews] review denied: [Bug 17258] SVG uses erroneous
cursor implementation : [Attachment 19018] Initial patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 9 13:35:46 PST 2008
Eric Seidel <eric at webkit.org> has denied Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 17258: SVG uses erroneous cursor implementation
http://bugs.webkit.org/show_bug.cgi?id=17258
Attachment 19018: Initial patch
http://bugs.webkit.org/attachment.cgi?id=19018&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
It looks like:
HashSet<RefPtr<SVGElement> > m_clients;
could easily cause cycles in the DOM, thus leaking whole subtrees. I suggest
making that a hashset of weak pointer, and then making it the client's
responsibility to clear themselves when they go away (I also wonder how that
would work with style sharing? looks like you disable it.)
Otherwise the patch looks OK.
More information about the webkit-reviews
mailing list