[webkit-reviews] review granted: [Bug 15003] Function.prototype.constructor should not be DontDelete/ReadOnly (Acid3 bug) : [Attachment 19003] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 14:09:48 PST 2008


Eric Seidel <eric at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 15003: Function.prototype.constructor should not be DontDelete/ReadOnly
(Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=15003

Attachment 19003: patch
http://bugs.webkit.org/attachment.cgi?id=19003&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
the code change looks fine.  I have concerns about the testing coverage.  It
should be possible to create a test which walked all functions on the window
object and checked to make sure that their prototype.constructor was mutable,
no?  What about all of the HTML* elements which are being changed by your
bindings .pl change.  I would think those could be tested in some automated
way.  Perhaps the ideal for this sort of thing is to find a way for
fast/window-properties.html  to dump all of the DontDelete|DontEnum|ReadOnly
information.


More information about the webkit-reviews mailing list