[webkit-reviews] review granted: [Bug 17009] [GTK] Webkit strips accents from some dead-key combinations : [Attachment 18990] Fix

[bugzilla-daemon at webkit.org]

Alp Toker <alp at atoker.com> has granted Pierre-Luc Beaudoin
<pierre-luc.beaudoin at collabora.co.uk>'s request for review:
Bug 17009: [GTK] Webkit strips accents from some dead-key combinations
http://bugs.webkit.org/show_bug.cgi?id=17009

Attachment 18990: Fix
http://bugs.webkit.org/attachment.cgi?id=18990&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
The copy-and-pasted string conversion code looks bogus -- just use
String::fromUTF8()?

Added a TODO about refcounting the GdkEvent. We need something like OwnPtr for
gdk to do this elegantly.

Looks fine otherwise, though I had to improve the ChangeLog entries.