[webkit-reviews] review granted: [Bug 16924] Shared PluginDatabase, PluginPackage, and PlugInInfoStore Implementations : [Attachment 18989] Updated patch to fix a few small issues with Wx and Qt changes

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has granted Rodney Dawes
<dobey at wayofthemonkey.com>'s request for review:
Bug 16924: Shared PluginDatabase, PluginPackage, and PlugInInfoStore
Implementations
http://bugs.webkit.org/show_bug.cgi?id=16924

Attachment 18989: Updated patch to fix a few small issues with Wx and Qt
changes
http://bugs.webkit.org/attachment.cgi?id=18989&action=edit

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
Looks good to me. Few small comments:

+/* Methods for dealing with loadable modules */

We prefer // style comments.

+ * Copyright (C) 2008 Collabora, LTd. All rights reserved.

Typo: LTd.

+String pathGetFileName(const String& path)
+{
+    notImplemented();
+    return String();
+}
+
+bool unloadModule(PlatformModule module)
+{
+    notImplemented();
+    return false;
+}

No need to name the args here.