[webkit-reviews] review requested: [Bug 17009] [GTK] Webkit strips accents from some dead-key combinations : [Attachment 18990] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 7 14:43:49 PST 2008


Pierre-Luc Beaudoin <pierre-luc.beaudoin at collabora.co.uk> has asked  for
review:
Bug 17009: [GTK] Webkit strips accents from some dead-key combinations
http://bugs.webkit.org/show_bug.cgi?id=17009

Attachment 18990: Fix
http://bugs.webkit.org/attachment.cgi?id=18990&action=edit

------- Additional Comments from Pierre-Luc Beaudoin
<pierre-luc.beaudoin at collabora.co.uk>
This fix the issue.  I tried it with my French Canadian keyboard layout and
dead keys (for à,ç,ê,ï,ù...) worked perfectly.

This was totally related to input method.  Each key event has to be filtered by
gtk_im_context_filter_keypress which will do the magic.  At first, my
characters were in screwed up: a utf8/utf16 conversion was missing.  

While at it, I implemented the isKeypad check and made disambiguateKeyDownEvent
behave more like other ports.


More information about the webkit-reviews mailing list