[webkit-reviews] review granted: [Bug 16798] <button> does not have type=submit (Acid3 bug) : [Attachment 18964] Patch to fix the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 7 13:38:48 PST 2008


Darin Adler <darin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 16798: <button> does not have type=submit (Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=16798

Attachment 18964: Patch to fix the bug
http://bugs.webkit.org/attachment.cgi?id=18964&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    return emptyAtom;

I think there should be an ASSERT_NOT_REACHED here. Also, I think it should
return "submit" rather than the empty string. But since it should never be
reached that doesn't really matter.

r=me


More information about the webkit-reviews mailing list