[webkit-reviews] review requested: [Bug 17178] [curl] when using winsock, downloadTimerCallback bails : [Attachment 18978] Don't call select when there are no valid file descriptors on any platform

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 6 21:24:13 PST 2008


Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 17178: [curl] when using winsock, downloadTimerCallback bails
http://bugs.webkit.org/show_bug.cgi?id=17178

Attachment 18978: Don't call select when there are no valid file descriptors on
any platform
http://bugs.webkit.org/attachment.cgi?id=18978&action=edit

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
Good point, I did some more testing and not calling select() seems to work fine
on Unix platforms too, so I've taken out the #if PLATFORM(WIN_OS) and I've also
initialized rc to 0 so that it won't be used uninitialized.


More information about the webkit-reviews mailing list