[webkit-reviews] review granted: [Bug 17191] HTML5: Client-side database queries should return values of type number : [Attachment 18958] Makes inserted numbers come back as numbers (not as strings)

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Kimmo Kinnunen
<kimmok at iki.fi>'s request for review:
Bug 17191: HTML5: Client-side database queries should return values of type
number
http://bugs.webkit.org/show_bug.cgi?id=17191

Attachment 18958: Makes inserted numbers come back as numbers (not as strings)
http://bugs.webkit.org/attachment.cgi?id=18958&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
This looks good.

No need for the braces around the for loop now. Remove them to match our style.


	     for (int i = 0; i < columnCount; i++) {
-		 // FIXME: Look at the column type?
-		 rows->addResult(statement.getColumnText(i));
+		 rows->addResult(statement.getColumnValue(i));
	     }