[webkit-reviews] review requested: [Bug 17179] [wx] Use PlatformWheelEvent for handling scroll wheel events : [Attachment 18951] Updated patch with ASSERTS added to ensure widths and heights are valid

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 5 22:13:29 PST 2008


Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 17179: [wx] Use PlatformWheelEvent for handling scroll wheel events
http://bugs.webkit.org/show_bug.cgi?id=17179

Attachment 18951: Updated patch with ASSERTS added to ensure widths and heights
are valid
http://bugs.webkit.org/attachment.cgi?id=18951&action=edit

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
So long as all the values are positive, there should not be any issues with
overflows, but you're right that we don't guarantee anywhere that the values
are positive. So I've added asserts to guard against negative x, y, width or
height values. I wasn't sure if it was okay to land this without the extra
review, so I've gone ahead and replaced the patch.


More information about the webkit-reviews mailing list