[webkit-reviews] review granted: [Bug 17179] [wx] Use
PlatformWheelEvent for handling scroll wheel events :
[Attachment 18923] Correctly handle PlatformWheelEvent in wx port
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 5 14:52:34 PST 2008
Darin Adler <darin at apple.com> has granted Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 17179: [wx] Use PlatformWheelEvent for handling scroll wheel events
http://bugs.webkit.org/show_bug.cgi?id=17179
Attachment 18923: Correctly handle PlatformWheelEvent in wx port
http://bugs.webkit.org/attachment.cgi?id=18923&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Looks fine, r=me.
+IntSize ScrollView::maximumScroll() const
+{
+ IntSize delta = (IntSize(contentsWidth(), contentsHeight()) -
IntSize(visibleWidth(), visibleHeight())) - scrollOffset();
+ delta.clampNegativeToZero();
+ return delta;
+}
Is there a guarantee that this can't overflow?
More information about the webkit-reviews
mailing list