[webkit-reviews] review granted: [Bug 16751] Failing to parse "html*.test" correctly as CSS selector (Acid3 bug) : [Attachment 18917] Shrink the patch a bit.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 16751: Failing to parse "html*.test" correctly as CSS selector (Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=16751

Attachment 18917: Shrink the patch a bit.
http://bugs.webkit.org/attachment.cgi?id=18917&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This looks like it relies on how bison handles conflicts. Anywhere we say
"selector" it could expand to "selector_with_trailing_whitespace" so it's all
about how it reduces.

Do we have sufficient test coverage for CSS selector parsing? I'd like to see a
lot of tests in this area.

r=me, more based on the theory that this is thoroughly tested rather than on my
certainty that I can validate this from proofreading the code.

I'd also like to see this grammar fixed to remove all the conflicts; that would
make it easier to understand the behavior by looking at the code, although it
would make the grammar more complex.