[webkit-reviews] review denied: [Bug 16979] Patch to conditionalize some CG/Cairo support in win32 : [Attachment 18835] Eighth revision based on Adam's comments.

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has denied Brent Fulgham <bfulgham at gmail.com>'s
request for review:
Bug 16979: Patch to conditionalize some CG/Cairo support in win32
http://bugs.webkit.org/show_bug.cgi?id=16979

Attachment 18835: Eighth revision based on Adam's comments.
http://bugs.webkit.org/attachment.cgi?id=18835&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
Index: WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h
===================================================================
--- WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h    
(revision 29726)
+++ WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h    
(working copy)
@@ -23,6 +23,10 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
  */
 
+#include "config.h"

This is wrong. We only include config.h from source files, not from header
files. I don't think the #if PLATFORM(CG) in this file is needed anymore now
that it has a CG-specific name. Ditto for
GraphicsContextPlatformPrivateCairo.h.