[webkit-reviews] review denied: [Bug 17175] Use of C++ compiler flags in CFLAGS : [Attachment 18909] Updated patch that adds and uses global_cxxflags

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 09:01:09 PST 2008


Alp Toker <alp at atoker.com> has denied Rodney Dawes <dobey at wayofthemonkey.com>'s
request for review:
Bug 17175: Use of C++ compiler flags in CFLAGS
http://bugs.webkit.org/show_bug.cgi?id=17175

Attachment 18909: Updated patch that adds and uses global_cxxflags
http://bugs.webkit.org/attachment.cgi?id=18909&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
>Index: JavaScriptCore/GNUmakefile.am
>===================================================================
>--- JavaScriptCore/GNUmakefile.am	(revision 29961)
>+++ JavaScriptCore/GNUmakefile.am	(working copy)
>@@ -149,14 +149,14 @@ Programs_minidom_SOURCES = \
>	JavaScriptCore/API/NodeList.c \
>	JavaScriptCore/API/minidom.c
> Programs_minidom_CPPFLAGS = $(global_cppflags)
>-Programs_minidom_CXXFLAGS = $(global_cflags)
>+Programs_minidom_CXXFLAGS = $(globacl_cxxflags) $(global_cflags)

Typo. Please test before requesting review.


More information about the webkit-reviews mailing list