[webkit-reviews] review requested: [Bug 17153] wxFont objects become invalid and cause a crash : [Attachment 18869] FontPlatformData uses wxFont as a value object

[bugzilla-daemon at webkit.org]

Kevin Watters <kevinwatters at gmail.com> has asked  for review:
Bug 17153: wxFont objects become invalid and cause a crash
http://bugs.webkit.org/show_bug.cgi?id=17153

Attachment 18869: FontPlatformData uses wxFont as a value object
http://bugs.webkit.org/attachment.cgi?id=18869&action=edit

------- Additional Comments from Kevin Watters <kevinwatters at gmail.com>
Fixes FontPlatformData issues. 

Reference counting of wxFont objects happens correctly now because they are
stored as value objects.  An enum is used to maintain the "uninitialized,"
"deleted," and "valid" states since all three are used by a HashTable holding
FontPlatformData objects.

computeHash now uses a hash of the string returned by
wxFont::GetNativeInfoDesc, which uniquely identifies a wxFont and all its
attributes.

Additionally, a missing delete in ImageWx.cpp is added.