[webkit-reviews] review denied: [Bug 17046] [GTK] Context menu fixes and customisation suport : [Attachment 18820] Make context menu native, fixed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 15:52:18 PST 2008


Alp Toker <alp at atoker.com> has denied Christian Dywan <christian at imendio.com>'s
request for review:
Bug 17046: [GTK] Context menu fixes and customisation suport
http://bugs.webkit.org/show_bug.cgi?id=17046

Attachment 18820: Make context menu native, fixed
http://bugs.webkit.org/attachment.cgi?id=18820&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
Needs better NULL safety and static WebCore strings for stock labels, and _
gettext should not be used for these strings, all as discussed on IRC.

(I also wonder if there's a less intrusive way to support itemCount(), though
this approach is OK I guess.)


More information about the webkit-reviews mailing list