[webkit-reviews] review cancelled: [Bug 17065] [GTK] Use a
consistent coding style : [Attachment 18762] Apply consistent
coding style
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 1 13:30:33 PST 2008
Christian Dywan <christian at imendio.com> has cancelled Christian Dywan
<christian at imendio.com>'s request for review:
Bug 17065: [GTK] Use a consistent coding style
http://bugs.webkit.org/show_bug.cgi?id=17065
Attachment 18762: Apply consistent coding style
http://bugs.webkit.org/attachment.cgi?id=18762&action=edit
------- Additional Comments from Christian Dywan <christian at imendio.com>
Properties using public api again.
Reintroducing core() and kit(), to be used consistently. Their implementations
now uses ->priv directly for efficiency.
Keeping changes to prefer WebCore internals over dogfood for efficiency.
> Frame* frame = priv->corePage->mainFrame();
has become
> Frame* frame = core(webView)->mainFrame();
due to the above change. I think this is a nice compromise in terms of
readability. If we use this consistently it should be pretty intuitive even to
newcomers.
More information about the webkit-reviews
mailing list