[webkit-reviews] review requested: [Bug 23060] REGRESSION (r38629): Cannot scroll a WebHTMLView using Home/End/Page up/Page down : [Attachment 26340] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 31 15:16:59 PST 2008


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 23060: REGRESSION (r38629): Cannot scroll a WebHTMLView using Home/End/Page
up/Page down
https://bugs.webkit.org/show_bug.cgi?id=23060

Attachment 26340: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=26340&action=review

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
Here is the revised patch. I don't want to change the default in the editable
case if you don't know exactly why the message is passed to super. Also,
'mistakingly' is valid English, just a bit out of use. I changed it though. ;-)


The same comment stands about the test.


More information about the webkit-reviews mailing list