[webkit-reviews] review requested: [Bug 17229] Inspector should show properties of all JS objects in Console : [Attachment 26335] updated patch with code style fixes

[bugzilla-daemon at webkit.org]

Konstantin Käfer <kkaefer at gmail.com> has asked	for review:
Bug 17229: Inspector should show properties of all JS objects in Console
https://bugs.webkit.org/show_bug.cgi?id=17229

Attachment 26335: updated patch with code style fixes
https://bugs.webkit.org/attachment.cgi?id=26335&action=review

------- Additional Comments from Konstantin Käfer <kkaefer at gmail.com>
> > -		    
formattedResult.appendChild(formatForConsole(parameters[i]));
> > +		    
formattedResult.appendChild(WebInspector.console._format(parameters[i]));
> 
> Why this change? The formatForConsole function just calls
> WebInspector.console._format.

formatForConsole() passes the parameter true for inline, but that is not what
we want in all cases. The attached patch fixes that and does treat
"console.log(window, document)" as inline again (thus they won't be
expnadable). Doing a "console.log(document)" (i.e. with only one element) will
now trigger the expandable mode.