[webkit-reviews] review granted: [Bug 22882] Make fast\encoding\char-encoding.html not depend on the ability to have reference fragments on data URLs : [Attachment 26325] patch with changelog diff fixed

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jungshik Shin
<jshin at chromium.org>'s request for review:
Bug 22882: Make fast\encoding\char-encoding.html not depend on the ability to
have reference fragments on data URLs
https://bugs.webkit.org/show_bug.cgi?id=22882

Attachment 26325: patch with changelog diff fixed
https://bugs.webkit.org/attachment.cgi?id=26325&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +	   possible to to skip it.

Typo: "to to".

> +	   - Enable UTF-8 test for U+221A

How did you ensure that this is safe now? Did you test on Tiger?

This should really be mentioned in ChangeLog.

> +	   * fast/encoding/resources/char-encoding-utils.js: Added.
> +	   (encode):
> +	   (testsDone):
> +	   (processResult):
> +	   (subframeLoaded):
> +	   (loadTimedOut):
> +	   (runTest):
> +	   (testEncode):

We normally try to describe changes for each file, not just as a global
overview. This is not very important in this case, but I think that you could
omit function names for brevity, as you don't have descriptions of individual
changes anyway.

r=me