[webkit-reviews] review granted: [Bug 23049] [jsfunfuzz] With blocks do not correctly protect their scope object : [Attachment 26330] Correctly guard the scope object

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 30 22:41:16 PST 2008


Darin Adler <darin at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 23049: [jsfunfuzz] With blocks do not correctly protect their scope object
https://bugs.webkit.org/show_bug.cgi?id=23049

Attachment 26330: Correctly guard the scope object
https://bugs.webkit.org/attachment.cgi?id=26330&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems like a good solution.

r=me

> +	   * fast/js/resources/with-scope-gc.js: Added.
> +	   (gc):
> +	   ():

You should remove the function names here. In particular, the "()" doesn't add
much.


More information about the webkit-reviews mailing list