[webkit-reviews] review requested: [Bug 23028] Enable web/dynamic font support for Chromium on Windows : [Attachment 26306] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 29 17:50:33 PST 2008


Jungshik Shin <jshin at chromium.org> has asked Maciej Stachowiak <mjs at apple.com>
for review:
Bug 23028: Enable web/dynamic font support for Chromium on Windows
https://bugs.webkit.org/show_bug.cgi?id=23028

Attachment 26306: patch 
https://bugs.webkit.org/attachment.cgi?id=26306&action=review

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
In addition to changes mentioned in comment #0, I changed WebCore.vcproj.

What I'm not sure about is whether I have to add an 'xcopy' statement to copy
header files in a newly added directory (platform/graphics/opentype) to
$WebKitBuildDirectory/include/WebCore). Because I've already added it to
AdditionalIncludeDirectory list in the vcproj file, the compilation went fine
without 'xcopy'.


More information about the webkit-reviews mailing list