[webkit-reviews] review granted: [Bug 23023] Remove incomplete support for opportunistic apcache entries : [Attachment 26289] proposed patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 23023: Remove incomplete support for opportunistic apcache entries
https://bugs.webkit.org/show_bug.cgi?id=23023

Attachment 26289: proposed patch
https://bugs.webkit.org/attachment.cgi?id=26289&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
r=me.

> Index: WebCore/loader/appcache/ApplicationCacheResource.h
> ===================================================================
> --- WebCore/loader/appcache/ApplicationCacheResource.h	(revision
39497)
> +++ WebCore/loader/appcache/ApplicationCacheResource.h	(working copy)
> @@ -40,7 +40,7 @@ public:
>	   Explicit = 1 << 2,
>	   Foreign = 1 << 3,
>	   Fallback = 1 << 4,
> -	   Opportunistic = 1 << 5,
> +	   // Bit 5 was used for opportunistic entries, which were removed from
the spec.
>	   Dynamic = 1 << 6

You should note in the changelog the reason you can't change Dynamic to use
bit-5.