[webkit-reviews] review granted: [Bug 23006] Many Loader::Host member functions are not safe to use reentrantly : [Attachment 26275] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 23006: Many Loader::Host member functions are not safe to use reentrantly
https://bugs.webkit.org/show_bug.cgi?id=23006

Attachment 26275: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=26275&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This patch is fine. We could also instead have ProcessingResource save and
restore the m_processingResource boolean, which would use more stack space but
less space in the object. It's really just fine as is. I'm going to say r=me

I don't understand your comment "There are no occurrences of crashes caused by
this bug that are reproducible by multiple people". Who ran into this? How did
you diagnose it?