[webkit-reviews] review requested: [Bug 22981] SVG-as-image redraw broken: svg-as-background-5.html LayoutTest fails : [Attachment 26257] Patch, testcases, changelog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 26 11:13:31 PST 2008
Simon Fraser (smfr) <simon.fraser at apple.com> has asked for review:
Bug 22981: SVG-as-image redraw broken: svg-as-background-5.html LayoutTest
fails
https://bugs.webkit.org/show_bug.cgi?id=22981
Attachment 26257: Patch, testcases, changelog
https://bugs.webkit.org/attachment.cgi?id=26257&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
Reviewed by NOBODY (OOPS!).
https://bugs.webkit.org/show_bug.cgi?id=22981
Repaints inside of an SVGImage were thrown on the floor,
which broke incremental painting due to loading, or SVG animation.
Fix this by assigning the SVGImage a ChromeClient subclass that passes
along repaints via a new method on ImageObserver, which also takes
a rect parameter for the changed rect, allowing incremental repaints.
Fix RenderImage::imageChanged to take advantage of this changedRect to
only repaint the changed parts of the image.
Tests: fast/backgrounds/animated-svg-as-background.html
fast/backgrounds/animated-svg-as-mask.html
fast/images/animated-svg-as-image.html
More information about the webkit-reviews
mailing list