[webkit-reviews] review denied: [Bug 22750] [gtk] webkit up to r39121 crash on image urls like http:///sitename.com : [Attachment 26238] patch which fixes a crash

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Alex Butenko
<a.butenka at gmail.com>'s request for review:
Bug 22750: [gtk] webkit up to r39121 crash on image urls like
http:///sitename.com
https://bugs.webkit.org/show_bug.cgi?id=22750

Attachment 26238: patch which fixes a crash
https://bugs.webkit.org/attachment.cgi?id=26238&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Please see http://webkit.org/coding/contributing.html and attach a new version
with a ChangeLog and an applyable patch.



> --- ResourceHandleSoup.cpp	2008-12-24 13:16:59.000000000 -0400
> +++ ResourceHandleSoup.cpp.new	2008-12-24 13:18:07.000000000 -0400
> @@ -335,7 +335,8 @@
>  
>      if (equalIgnoringCase(protocol, "data"))
>	   return startData(urlString);
> -    else if (equalIgnoringCase(protocol, "http") ||
equalIgnoringCase(protocol, "https"))
> +    else if ( (equalIgnoringCase(protocol, "http") ||
equalIgnoringCase(protocol, "https") ) &&
> +		  
SOUP_URI_VALID_FOR_HTTP(soup_uri_new(urlString.utf8().data())))
>	   return startHttp(urlString);


why did you decide to do this check here and not within startHttp? Is there
anyone else calling startHttp?