[webkit-reviews] review requested: [Bug 22624] [SOUP][GTK] Need API to get SoupSession from WebKit. : [Attachment 26240] API to retrieve the soup session from the view #2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 24 11:55:55 PST 2008


Christian Dywan <christian at imendio.com> has asked  for review:
Bug 22624: [SOUP][GTK] Need API to get SoupSession from WebKit.
https://bugs.webkit.org/show_bug.cgi?id=22624

Attachment 26240: API to retrieve the soup session from the view #2
https://bugs.webkit.org/attachment.cgi?id=26240&action=review

------- Additional Comments from Christian Dywan <christian at imendio.com>
(In reply to comment #4)
> (From update of attachment 26230 [review])
> General comments:
>   - Coding Style, sepcially brackets on the if/else :)
Updated to correct the coding style.

>   - on QtWebKit we allow to have something like a SoupSession per WebView...
> would that make sense as well? E.g. sometimes you do not want two different
> WebView to share the same cookie pool? If we want that the WebView should
hold
> a SoupSession and there should be one default session so by default every
> WebView is sharing this session?
That is actually the plan, and we discussed this a bit already. We figured it
would be good to allow for it in the API, by having a view specific function,
and in a second step add the logic for individual sessions and another
function.

> It would be cool if we could unite this with the LogNetworking WTFLogChannel
> (WebCore/platform/Logging.h)
I changed the logging part to look for WEBKIT_DEBUG with a value of 'network',
similar to GTK_DEBUG or G_DEBUG. It seems like a good idea to integrate it with
WebCore's logging, however probably not in this same patch.


More information about the webkit-reviews mailing list