[webkit-reviews] review granted: [Bug 22980] WebCore uses more thread specific keys than it really needs : [Attachment 26229] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 23 13:07:12 PST 2008
Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 22980: WebCore uses more thread specific keys than it really needs
https://bugs.webkit.org/show_bug.cgi?id=22980
Attachment 26229: proposed patch
https://bugs.webkit.org/attachment.cgi?id=26229&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> +#if PLATFORM(MAC)
> + delete m_cachedConverterTEC;
> +#endif
> +#if USE(ICU_UNICODE)
> + delete m_cachedConverterICU;
> +#endif
> +
> + delete m_eventNames;
> + delete m_atomicStringTable;
> +
> + ASSERT(m_emptyString->hasOneRef());
> + delete m_emptyString;
> +}
Why not use an OwnPtr?
r=me
More information about the webkit-reviews
mailing list