[webkit-reviews] review granted: [Bug 19703] Crash in WebCore::InsertNodeBeforeCommand::doUnapply() : [Attachment 26218] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 23 12:12:56 PST 2008

John Sullivan <sullivan at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 19703: Crash in WebCore::InsertNodeBeforeCommand::doUnapply()

Attachment 26218: patch

------- Additional Comments from John Sullivan <sullivan at apple.com>
Two comments:

1) my eyes have gone partly numb reviewing this patch, so I'm not 100%
confident that I would have noticed minor errors
2) it's not obvious from these changes whether the various vaguely-specified
bug reports have actually been fixed

But still, I didn't see any actual problems, and I saw lots of robustification.
r=me assuming it passes the current layout tests.


More information about the webkit-reviews mailing list