[webkit-reviews] review granted: [Bug 22957] RenderPath clean-up for strokeContains : [Attachment 26199] Move strokeContains back to RenderPath.cpp
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 23 08:44:37 PST 2008
Darin Adler <darin at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 22957: RenderPath clean-up for strokeContains
https://bugs.webkit.org/show_bug.cgi?id=22957
Attachment 26199: Move strokeContains back to RenderPath.cpp
https://bugs.webkit.org/attachment.cgi?id=26199&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + bool strokeContains(StrokeStyleApplier* applier, const FloatPoint&)
const;
Our style is to omit the argument name when the type makes it clear. Hence, no
"applier" needed here.
> FloatRect strokeBoundingRect(StrokeStyleApplier* applier = 0);
Same here (not changed in this patch).
r=me
More information about the webkit-reviews
mailing list