[webkit-reviews] review granted: [Bug 22957] RenderPath clean-up for strokeContains : [Attachment 26199] Move strokeContains back to RenderPath.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 23 08:44:37 PST 2008

Darin Adler <darin at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 22957: RenderPath clean-up for strokeContains

Attachment 26199: Move strokeContains back to RenderPath.cpp

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   bool strokeContains(StrokeStyleApplier* applier, const FloatPoint&)

Our style is to omit the argument name when the type makes it clear. Hence, no
"applier" needed here.

>	   FloatRect strokeBoundingRect(StrokeStyleApplier* applier = 0);

Same here (not changed in this patch).


More information about the webkit-reviews mailing list