[webkit-reviews] review requested: [Bug 11850] Webarchive fails to save images referenced in CSS : [Attachment 26215] Patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 22 15:04:04 PST 2008

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked Darin Adler
<darin at apple.com> for review:
Bug 11850: Webarchive fails to save images referenced in CSS

Attachment 26215: Patch v4

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Changes since Patch v3:

- Reverted const-ness of StyleBase::stylesheet().
- Removed const-ness from all addSubresourceStyleURLs() methods.
- Replaced switch() statements with virtual methods on CSSRule and CSSValue
subclasses (OO design FTW!).
- Removed abuse of RefPtr<> in favor of raw pointers.
- Renamed max variables.
- Inlined null-checked variable declarations into if() statements.
- Called immediate superclass instead of
- Reverted changes to CSSBorderImageValue.h to include Rect.h (although it only
works because each source file where it's included also includes Rect.h).
- Tweaked ProcessingInstruction::addSubresourceAttributeURLs() to call

More information about the webkit-reviews mailing list