[webkit-reviews] review requested: [Bug 22357] Crash when setting className via SVG className.baseVal : [Attachment 26211] Possible patch to issue 22357
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 22 12:14:29 PST 2008
Glenn Wilson <gwilson at google.com> has asked for review:
Bug 22357: Crash when setting className via SVG className.baseVal
https://bugs.webkit.org/show_bug.cgi?id=22357
Attachment 26211: Possible patch to issue 22357
https://bugs.webkit.org/attachment.cgi?id=26211&action=review
------- Additional Comments from Glenn Wilson <gwilson at google.com>
Ah, good catch. The previous patch would create the namedAttrMap regardless,
which doesn't seem correct. It should only create the namedAttrMap if it
doesn't exist and it's not being cleared.
This new patch only creates namedAttrMap if it exists and the class name is
being set, not cleared.
More information about the webkit-reviews
mailing list