[webkit-reviews] review requested: [Bug 11850] Webarchive fails to save images referenced in CSS : [Attachment 26184] Patch v3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 21 08:33:36 PST 2008
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked Darin Adler
<darin at apple.com> for review:
Bug 11850: Webarchive fails to save images referenced in CSS
https://bugs.webkit.org/show_bug.cgi?id=11850
Attachment 26184: Patch v3
https://bugs.webkit.org/attachment.cgi?id=26184&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
NOTE: The bulk of this patch is layout test source and output.
Changes since Patch v2:
- Added StyleSheet::completeURL() and CSSStyleSheet::completeURL() with tests
to address concerns in Comment #12. Switched CSSParser.cpp to use
completeURL(). See also Comment #17.
- Removed baseURL parameter from being passed around now that
CSSStyleSheet::completeURL() exists.
- Fixed indentation of switch() statement in
CSSMutableStyleDeclaration::addSubresourceStyleURLs().
- Made StyleBase::stylesheet() const.
More information about the webkit-reviews
mailing list