[webkit-reviews] review requested: [Bug 22929] Memory Regression from r39309 : [Attachment 26148] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 19 10:56:29 PST 2008


Peter Kasting <pkasting at google.com> has asked Dave Hyatt <hyatt at apple.com> for
review:
Bug 22929: Memory Regression from r39309
https://bugs.webkit.org/show_bug.cgi?id=22929

Attachment 26148: patch v1
https://bugs.webkit.org/attachment.cgi?id=26148&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This ought to fix the error message, and if the memory regression is caused by
the same problem it should fix that too.  I'm not sure how to test that locally
so I'll be interested in the performance of this in the test suite.

In short, the issue was that in the old code, we always deleted the decoder, so
we always called setData() after it.  Now that we don't delete the decoder all
the time, we shouldn't always call setData() again either.  Because BitmapImage
seems like the wrong place to know how ImageSource is handling a clear() call
internally, I moved this logic into ImageSource::clear() itself.


More information about the webkit-reviews mailing list