[webkit-reviews] review requested: [Bug 22898] [GTK] Patch to complete GtkPrint API : [Attachment 26145] updated patch that fixes CodingStyle

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 19 09:56:07 PST 2008

Colin Leroy <colin at colino.net> has asked  for review:
Bug 22898: [GTK] Patch to complete GtkPrint API

Attachment 26145: updated patch that fixes CodingStyle

------- Additional Comments from Colin Leroy <colin at colino.net>

Here's an updated patch that fixes the mentioned style issues. Sorry about
indentations, my editor has a tendancy to replace 8 spaces with 1 tab and I
usually prefer this coding style, so I let that be :) I doubled checked them
this time.

About NULL usage in c++, I left them as is because I've noticed lots of NULLs
in other cpp files, and I'm not sure 0x0 would be nicer... Feel free to tell me
what you'd prefer if you really prefer I don't add NULLs :)

I've left the API in webframe.h, I don't mind an extra delay with this patch,
and OTOH i'd like to have a defined API - there's another place where I could
use it, a future Claws Mail plugin.


More information about the webkit-reviews mailing list