[webkit-reviews] review granted: [Bug 22918] Web Inspector crashes if no node is selected when it is launched (Qt port only) : [Attachment 26121] When Web Inspector is launched without an associated node, call show() instead of inspect().

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 19 00:07:02 PST 2008


Tor Arne Vestbø <tavestbo at trolltech.com> has granted Yael
<yael.aharon at nokia.com>'s request for review:
Bug 22918: Web Inspector crashes if no node is selected when it is launched (Qt
port only)
https://bugs.webkit.org/show_bug.cgi?id=22918

Attachment 26121: When Web Inspector is launched without an associated node,
call show() instead of inspect().
https://bugs.webkit.org/attachment.cgi?id=26121&action=review

------- Additional Comments from Tor Arne Vestbø <tavestbo at trolltech.com>
Good catch!

> +	       if (d->hitTestResult.d)

We can probably use isNull() instead of d directly here. I'll land it with that
change.

Thanks!


More information about the webkit-reviews mailing list