[webkit-reviews] review granted: [Bug 22925] The JIT's handling of JSImmediate values is broken on x86-64. : [Attachment 26132] Down to 1 regression!

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 22925: The JIT's handling of JSImmediate values is broken on x86-64.
https://bugs.webkit.org/show_bug.cgi?id=22925

Attachment 26132: Down to 1 regression!
https://bugs.webkit.org/attachment.cgi?id=26132&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +	   
> +	   This fix honors previous behavoir.  A better fix in the long run
> +	   (when the JIT is enabled by default) may be to change JSImmediate.h
> +	   so it no longer relies on the upper bits of the pointer,... though
> +	   if we're goign to change JSImmediate.h for 64-bit, we probably may

Typo.  "going".

> +	   as well change the format so that the full range of 32-bit ints can
> +	   be stored, rather than just 31-bits. [hrrrm, maybe we want 33-bit
> +	   ints, so that all results of bit-ops can be represented in immediate

> +	   format?]

Please add a reference to this bug.

r=me