[webkit-reviews] review granted: [Bug 21855] REGRESSION (r37323): Gmail complains about popup blocking when opening a link : [Attachment 26118] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 18 09:44:05 PST 2008


Geoffrey Garen <ggaren at apple.com> has granted Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 21855: REGRESSION (r37323): Gmail complains about popup blocking when
opening a link
https://bugs.webkit.org/show_bug.cgi?id=21855

Attachment 26118: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=26118&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
> +	   function test()
> +	   {
> +	       if (window.layoutTestController) {
> +		   eventSender.mouseMoveTo(2, 2);
> +		   eventSender.scheduleAsynchronousClick();
> +		   // eventSender.mouseDown();
> +		   // eventSender.mouseUp();
> +	       }
> +	   }

Please remove the commented-out code.

For future reference, eventSender has a "leapForward" method that allows you to
pretend that time has passed between events. I'm not sure if that would have
been useful to you here or not.

Another way to answer Alexey's question: We don't know of any cases other than
event handling where the dynamic global object should be something other than
the lexical global object. But maybe there are some.

r=me


More information about the webkit-reviews mailing list