[webkit-reviews] review denied: [Bug 22880] Convert javascript Number Object or Boolean Object to Qt types in QtWebKit. : [Attachment 26056] This patch implements the feature

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <tavestbo at trolltech.com> has denied Tor Arne Vestbø
<tavestbo at trolltech.com>'s request for review:
Bug 22880: Convert javascript Number Object or Boolean Object to Qt types in
QtWebKit.
https://bugs.webkit.org/show_bug.cgi?id=22880

Attachment 26056: This patch implements the feature
https://bugs.webkit.org/attachment.cgi?id=26056&action=review

------- Additional Comments from Tor Arne Vestbø <tavestbo at trolltech.com>
> +    // if hint is const QVariant& and type is Object, 
> +    // because the visitedObjects check at the beginging of this function,
> +    // make sure it's handled as QVariantMap upon the first time entering
this function
> +    if (hint == (QMetaType::Type) qMetaTypeId<QVariant>() && type == Object)

> +	   hint = QMetaType::QVariantMap;

I think we should remove the object from the visitedObjects when recursing with
the auto-detect flag instead.

>	   case QMetaType::QVariantMap: 
> +		   // Javascript built-in Number and Boolean object don't have
properties,
> +		   // convert them to double and bool respectively

Some auto-tests for this would be nice.