[webkit-reviews] review cancelled: [Bug 22898] [GTK] Patch to allow batch printing to file : [Attachment 26101] Fixed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 18 01:02:44 PST 2008

Colin Leroy <colin at colino.net> has cancelled Colin Leroy <colin at colino.net>'s
request for review:
Bug 22898: [GTK] Patch to allow batch printing to file

Attachment 26101: Fixed patch

------- Additional Comments from Colin Leroy <colin at colino.net>

Here's a rather bigger patch that aims to complete the GtkPrint API and make it

What it does:
- WebKit/gtk/webkit/webkitwebframe.cpp: Factorizes code between print and
print_to_file, as little of it changes in both cases; Removes the error dialog,
leaving error handling to the caller; Adds the ability to specify page setup
and print settings in the Print case too, which lets the calling app have a
"Page setup" menu, and let it get back updated print settings in order to
remember them. This adds a few parameters to the functions, but helps
applications to have a full implementation; and add my name to the Copyright
- WebKit/gtk/webkit/webkitwebframe.h: Make the API public; the only annoyance
is that the API will be different whether compiled against GTK 2.10+ or not, as
the parameters type didn't exist before, it's not possible anymore to have
filler-functions printing a g_warning().
- WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp: Update code to use the new
API, with the minimal changes needed - just error handling the same way as it
was before, only at the caller level.

I tried to think of possible shortcomings to this API, because we wouldn't want
to modify a public API, but I think it's complete. _print_to_file() shows no
dialog, so there's no possibility to have updated settings after. GtkPageSetup
can't be modified from inside a print dialog, so there are no modifications to

More information about the webkit-reviews mailing list