[webkit-reviews] review granted: [Bug 22909] The JSC JIT doesn't yet even run "Hello, world" on x86-64. : [Attachment 26110] The patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 22909: The JSC JIT doesn't yet even run "Hello, world" on x86-64.
https://bugs.webkit.org/show_bug.cgi?id=22909

Attachment 26110: The patch
https://bugs.webkit.org/attachment.cgi?id=26110&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +    typedef struct
> +    {
> +	   void* first;
> +	   void* second;
> +    } VoidPtrPair;

This should use our normal struct format. You can fix the union at the same
time if you like.

> +#if PLATFORM(X86_64)
> +	       // Temporary measure - for now, this will force all arguments
onto the stack (regparm(0) does not appear to have any effect).
> +	       // We can allow register passing here, and move the writes of
these values into the trampoline.
> +	       void*, void*, void*, void*, void*, void*,

Ick!  Please add a FIXME preferably with a bug number.

>  #define ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS 1
>  #define ENABLE_JIT_OPTIMIZE_ARITHMETIC 1
>  #endif
> +#if !defined(ENABLE_JIT) && PLATFORM(X86_64) && PLATFORM(MAC) && 0
> +#define ENABLE_JIT 1
> +#define WTF_USE_CTI_ARGUMENT 1
> +#endif

Please remove the && 0 and instead set ENABLE_JIT and WTF_USE_CTI_ARGUMENT to
0.

r=me