[webkit-reviews] review denied: [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend : [Attachment 26099] Implementation of some (unimplemented) functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 17 13:03:40 PST 2008

Holger Freyther <zecke at selfish.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 16356: [GTK] Integrate GStreamer video with the graphics backend

Attachment 26099: Implementation of some (unimplemented) functions

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +	   // Splitting the capability by comma and taking the first part
> +	   // as capability can be something like "audio/x-wavpack,
> +	   gchar* type = g_strsplit(gst_caps_to_string(caps), ",", 2)[0];
> +

LEAK, LEAK, LEAK! I suffered from this with hald 0.5.9 on my Neo1973.
-strsplit. Please redo this and use valgrind or memprof to check that you don't

More information about the webkit-reviews mailing list