[webkit-reviews] review denied: [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend : [Attachment 26099] Implementation of some (unimplemented) functions

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 16356: [GTK] Integrate GStreamer video with the graphics backend
https://bugs.webkit.org/show_bug.cgi?id=16356

Attachment 26099: Implementation of some (unimplemented) functions
https://bugs.webkit.org/attachment.cgi?id=26099&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +	   // Splitting the capability by comma and taking the first part
> +	   // as capability can be something like "audio/x-wavpack,
framed=(boolean)false"
> +	   gchar* type = g_strsplit(gst_caps_to_string(caps), ",", 2)[0];
> +


LEAK, LEAK, LEAK! I suffered from this with hald 0.5.9 on my Neo1973.
http://library.gnome.org/devel/glib/stable/glib-String-Utility-Functions.html#g
-strsplit. Please redo this and use valgrind or memprof to check that you don't
leak.