[webkit-reviews] review granted: [Bug 22897] Clear bytecode vector after JITing : [Attachment 26087] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 17 10:00:21 PST 2008


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 22897: Clear bytecode vector after JITing
https://bugs.webkit.org/show_bug.cgi?id=22897

Attachment 26087: patch
https://bugs.webkit.org/attachment.cgi?id=26087&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   (JSC::CodeBlock::handlerForBytecodeOffset): Don't assert that the
offset
> +	   is less than the size of the bytecode vector since it may have been
cleared
> +	   and therefore 0.

I think it would be better to keep around the size of the bytecode vector in a
separate variable in debug versions so we could keep these assertions.

r=me


More information about the webkit-reviews mailing list