[webkit-reviews] review requested: [Bug 22755] Next step to Timers in Workers: moving timer code from other places to DOMTimer. : [Attachment 26084] updated patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 22755: Next step to Timers in Workers: moving timer code from other places
to DOMTimer.
https://bugs.webkit.org/show_bug.cgi?id=22755

Attachment 26084: updated patch
https://bugs.webkit.org/attachment.cgi?id=26084&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Changed code per feedback from Darin.

I've moved timeoutsMap back to Document (undoing the part of the change) since
making it a global was not a good idea. It would have issues listed below,
which would unnecessary complicate the code, so I left it on the Document with
the idea to move it to ScriptExecutionContext very soon so Workers could use it
too:
- It would have to become ThreadSpecific in case of using in Workers
- It would have to become a map-of-maps or something else to separate IDs for
each window
- the code removing IDs from this map would be potentially a mem-leak-prone
code.