[webkit-reviews] review requested: [Bug 22650] Make most of SVGMatrix bindings generated again : [Attachment 26067] SVGMatrix v2 (immutable attribute)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 16 13:50:55 PST 2008

Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked Eric Seidel
<eric at webkit.org> for review:
Bug 22650: Make most of SVGMatrix bindings generated again

Attachment 26067: SVGMatrix v2 (immutable attribute)

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Per our discussion, I attempted implementing SVGMatrix, a wrapper around
AffineTransform, but it kind got complicated with ObjC bindings and various
places where there's a need for implicit AffineTransform<->SVGMatrix
conversion, so instead I went with plan B.

This is a modification of the previous patch, with the exception that instead
of hard-coding SVGMatrix-specific behavior into code generator, I added
"Immutable" attribute (which is already used on IDL properties) to methods,
with the following behavior:

If a method is marked as "Immutable", it will return a new instance as a result
rather than the reference to the existing instance (self.)

More information about the webkit-reviews mailing list